Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

F/zmq #145

Merged
merged 64 commits into from
Jun 28, 2022
Merged

F/zmq #145

merged 64 commits into from
Jun 28, 2022

Conversation

nikhar-abbas
Copy link
Collaborator

@nikhar-abbas nikhar-abbas commented Jun 9, 2022 •
edited
Loading

Description and Purpose

Enable zeroMQ interface - specifically set up for yaw control

Type of change

What types of change is it?
Select the appropriate type(s) that describe this PR

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Github issues addressed, if one exists

Examples/Testing, if applicable

Added example

Checklist

  • Add example
  • Update docs with API changes

@nikhar-abbas
cleanup api change table
c86d2cc
@nikhar-abbas
Merge remote-tracking branch 'upstream/develop' into develop
356b225
@nikhar-abbas
Merge remote-tracking branch 'upstream/develop' into develop
e1014b7
@nikhar-abbas
Merge remote-tracking branch 'upstream/develop' into develop
c506615
@nikhar-abbas
zeromq client and f90 files - initia lcommit
1fd87b7
@nikhar-abbas
add zmq install reqs
7eb9249
@nikhar-abbas
remove yaw-by-ipc
2ca2859
@nikhar-abbas
typo fix
983286c
@nikhar-abbas
add zeroMQ interface to registry and source - enable zeroMQ for yaw c…
faab3d3 
…ontrol
@nikhar-abbas
cleanup to compile, move ZMQ_Mode to flags, write DISCONS
03d87b0
@nikhar-abbas
Merge remote-tracking branch 'upstream/develop' into f/zmq
f98735b
@nikhar-abbas
only set ZMQ_Client if flag is enabled
281c1b4
@nikhar-abbas
fix bug in discons
d6e7309
@nikhar-abbas
minor updates and add sim with wind direction
4e3a985
@nikhar-abbas
change to dict inputs for control interface
65c35da
@nikhar-abbas
add zmq example
cd5a0f6
@nikhar-abbas
Revert "remove yaw-by-ipc"
1709d30 
This reverts commit 2ca2859.
@nikhar-abbas
Enable Yaw-by-ipc again
87a5967
@nikhar-abbas
update and execute zeromq example
2c85969
@nikhar-abbas
add zmq to dependencies
019eed4
@nikhar-abbas
sudo for apt-get
0ea8ec2
@nikhar-abbas
libzmq3-dev typo
0986e6d
@nikhar-abbas
setup cmake
683f744
@nikhar-abbas
rename example 16 to 17
576cd72
@nikhar-abbas
Merge remote-tracking branch 'upstream/develop' into f/zmq
b7974cd
@nikhar-abbas
read empty line
9e3aef5
@nikhar-abbas
update types, regen discons
6caf12f
@nikhar-abbas
fix build path
07f902a
@nikhar-abbas
remove non-ubuntu examples, type in cmake command
8e9f1b4
@nikhar-abbas
Set ROSCO=True
39cd7e6
@nikhar-abbas nikhar-abbas mentioned this pull request Jun 14, 2022
Closed
8 tasks
dzalkind
dzalkind requested changes Jun 21, 2022
View reviewed changes
Copy link
Collaborator

@dzalkind dzalkind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work and contribution overall. Would be nice to demo the new yaw controller at some point. Can you clean up the few things I pointed out?

ROSCO/src/Controllers.f90 Outdated Show resolved Hide resolved
ROSCO/src/ReadSetParameters.f90 Show resolved Hide resolved
ROSCO/src/ReadSetParameters.f90 Outdated Show resolved Hide resolved
ROSCO_toolbox/utilities.py Show resolved Hide resolved
ROSCO_toolbox/utilities.py Outdated Show resolved Hide resolved
ROSCO_toolbox/utilities.py Outdated Show resolved Hide resolved
nikhar-abbas and others added 20 commits June 22, 2022 12:02
@nikhar-abbas
execute with runpy instead of importlib
c80be0e
@nikhar-abbas
move zmq interface classes to control_interface
de5d309
@nikhar-abbas
Properly shutdown ZMQ interface
00f19c1
@nikhar-abbas
add IEA15MW_ExtInterface.yaml
47b5b0d
@dzalkind
Incorporate runFAST stuff from WEIS, clean up
9063107
@dzalkind
Remove specific rosco_dll
1a0e98e
@nikhar-abbas
Publish artifacts from examples
28c7a32
@dzalkind
Clean up examples following runFAST business
fd3d34b
@dzalkind
Merge remote-tracking branch 'nja/f/zmq' into f/zmq
0ad4f73
@nikhar-abbas
move archive artifacts
80b5460
@dzalkind
Fix build dir in example 17
55eaba4
@dzalkind
Switch install/develop in pytools CI
94bcb6b
@nikhar-abbas
archive even if exampless fail
dcac9af
@nikhar-abbas
Merge branch 'f/zmq' of https://github.com/nikhar-abbas/ROSCO into f/zmq
006666e
@nikhar-abbas
add zmq build instructions
f4802df
@nikhar-abbas
cleanup and rename sim
d527606
@dzalkind
Remove BITS_IN_ADDR stuff
6156474
@dzalkind
Pass case_inputs and rosco_dll to runFAST object
0db4e6c
@dzalkind
Pass correct DLL_FileName for external control
bf8601c
@dzalkind
Tidy example 15 commenting
b165640
@dzalkind dzalkind merged commit 40a4edc into NREL:develop Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzalkind dzalkind dzalkind approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikhar-abbas @dzalkind