Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codecov fails to submit to the dashboard for PR's from forks #57

Closed
rafmudaf opened this issue Feb 4, 2020 · 1 comment
Closed

Codecov fails to submit to the dashboard for PR's from forks #57

rafmudaf opened this issue Feb 4, 2020 · 1 comment
Assignees
@rafmudaf

Comments

@rafmudaf
Copy link
Collaborator

rafmudaf commented Feb 4, 2020 •
edited
Loading

Bug description
The Codecov utility in the GitHub Actions workflow fails to find the codecov.io secret keys when a pull request is submitted from a fork of NREL/FLORIS. This causes the CI to fail even when all tests pass.

Evidently, someone is working on it: codecov/codecov-action#29

To Reproduce
Open a pull request from a fork and see that it fails. Like this one:https://github.com/nrel/floris/actions/runs/34813096

Expected behavior
I'd like these to either not try to upload results to the dashboard or successfully upload results.

Floris Version
Current develop branch.
@rafmudaf rafmudaf self-assigned this Feb 4, 2020
@rafmudaf
Copy link
Collaborator Author

Fixed!

bayc pushed a commit that referenced this issue Jan 19, 2022
@rafmudaf
Merge pull request #57 from paulf81/reorganize_examples
6044d4d 
Reorganize examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rafmudaf rafmudaf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rafmudaf