Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tmy update for meteosat 15min #64

Merged
merged 2 commits into from
Dec 7, 2023
Merged

tmy update for meteosat 15min #64

merged 2 commits into from
Dec 7, 2023

Conversation

bnb32
Copy link
Collaborator

@bnb32 bnb32 commented Dec 6, 2023

Modified tmy calc to allow for 15 min input

@bnb32 bnb32 requested a review from grantbuster December 6, 2023 15:46
if ti_len % 8760 == 0:
freq = f'{60 * 8760 // ti_len}min'
elif ti_len % 8784 == 0:
freq = f'{60 * 8784 // ti_len}min'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good although i think the most robust way to do this is calculate the forward-difference TimeDelta on the time index and then take the mode. I did this somewhere.... maybe in the cloud data handler? doesnt matter, what you have is fine.

@bnb32 bnb32 merged commit 0f45b79 into main Dec 7, 2023
4 checks passed
@bnb32 bnb32 deleted the bnb/dev branch December 7, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants