Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bnb/dev #148

Merged
merged 6 commits into from
May 12, 2023
Merged

Bnb/dev #148

merged 6 commits into from
May 12, 2023

Conversation

bnb32
Copy link
Collaborator

@bnb32 bnb32 commented May 4, 2023

Upper/lower case issue during recursive feature lookup resolved. Can remove ERA datahandler as this allows the DataHandlerNC to be used.

@bnb32 bnb32 requested a review from ppinchuk May 9, 2023 19:14
Copy link
Collaborator

@ppinchuk ppinchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fairly short and sweet. Dealing with string cases is always a pain lol

sup3r/bias/bias_calc.py Show resolved Hide resolved
sup3r/preprocessing/data_handling.py Show resolved Hide resolved
@bnb32 bnb32 force-pushed the bnb/dev branch 4 times, most recently from b944d6b to 6fe5266 Compare May 12, 2023 13:53
@bnb32 bnb32 merged commit 64372d7 into main May 12, 2023
@bnb32 bnb32 deleted the bnb/dev branch May 12, 2023 18:51
github-actions bot pushed a commit that referenced this pull request May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants