Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gb/skill #163

Merged
merged 2 commits into from
Aug 25, 2023
Merged

Gb/skill #163

merged 2 commits into from
Aug 25, 2023

Conversation

grantbuster
Copy link
Member

No description provided.

@grantbuster grantbuster requested a review from bnb32 August 24, 2023 22:20
@grantbuster
Copy link
Member Author

@bnb32 can you think of any other common skill test metrics we should add?

Here's an example of a high-complexity skill evaluation. Not sure how much value all of this adds... https://agupubs.onlinelibrary.wiley.com/doi/10.1029/2022JD036659

and an example of a simple evaluation: https://www.sciencedirect.com/science/article/pii/S0048969721056576

I would really like to just present bias and KS test statistic, especially since we're going to be looking at more variables than other studies.

@bnb32
Copy link
Collaborator

bnb32 commented Aug 25, 2023

@bnb32 can you think of any other common skill test metrics we should add?
No I think this is plenty of coverage. Looks good. Is the plan to compare various non bias corrected GCM data performance against wtk?

Copy link
Collaborator

@bnb32 bnb32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward. Looks good.

@grantbuster
Copy link
Member Author

@bnb32 can you think of any other common skill test metrics we should add?
No I think this is plenty of coverage. Looks good. Is the plan to compare various non bias corrected GCM data performance against wtk?

Yep the idea is to document 1) which GCMs have the best historical skill and 2) the variety of inter-model projected changes. This PR is just for 1. The goal is to do this for all power system variables (this has been done all over for T/Pr but not for wind+solar+humidity) to inform which GCMs we look at.

@grantbuster grantbuster merged commit e1ae1b5 into main Aug 25, 2023
@grantbuster grantbuster deleted the gb/skill branch August 25, 2023 15:00
github-actions bot pushed a commit that referenced this pull request Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants