-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to specify duplicate command names in Pipeline #174
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, man! Seems like this was just a bit tedious but easier than expected? Based on the test it looks like pipeline_step doesn't need to be specified explicitly, but I'm not seeing where in the code the implicit specification is handled?
Yea, you're 100% right about it being easier than expected. When I was ding the GAPs refactor, I realized it would be a non-negligible amount of changes to integrate this feature, which I had no idea if you guys needed or even wanted. I think at that time I decided to take the conservative approach and told myself "sup3r will just behave as if its still running on the reV pipeline". I made a mental note of that and moved on, which is probably why I was remembering that it would be "difficult". Now that there's appetite for this, I think the 100 extra lines are totally worth it. The |
@ppinchuk Awesome, thanks for knocking this out so quickly. The parsing looks good to me! |
Add ability to specify duplicate command names in Pipeline
Short example on how to specify duplicate pipeline steps is here.