Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix get_clearsky_ghi function to use correct time slice #176

Merged
merged 7 commits into from
Nov 13, 2023
Merged

fix get_clearsky_ghi function to use correct time slice #176

merged 7 commits into from
Nov 13, 2023

Conversation

spodgorny9
Copy link
Collaborator

No description provided.

grantbuster
grantbuster requested changes Nov 9, 2023
View reviewed changes
Copy link
Member

@grantbuster grantbuster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but you need to deal with pylint issues and make sure the tests pass (suggest running on local first). Pylint is every new developer's favorite feature of our repos, have fun :)

sup3r/preprocessing/data_handling/nc_data_handling.py Outdated Show resolved Hide resolved
grantbuster
grantbuster approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@grantbuster grantbuster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! thanks.

@spodgorny9 spodgorny9 merged commit b24736f into main Nov 13, 2023
5 checks passed
@spodgorny9 spodgorny9 deleted the sp/fix_clearsky branch November 13, 2023 16:31
github-actions bot pushed a commit that referenced this pull request Nov 13, 2023
@spodgorny9
Merge pull request #176 from NREL/sp/fix_clearsky
86fbb3d 
fix get_clearsky_ghi function to use correct time slice
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grantbuster grantbuster grantbuster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spodgorny9 @grantbuster