stdev and mean hot fix #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grantbuster
approved these changes
Nov 15, 2023
| @@ -870,6 +872,9 @@ def get_loss_fun(loss): | |||
| "MeanSquaredError" is requested, this will return | |||
| an instance of tf.keras.losses.MeanSquaredError() | |||
| """ | |||
| kwargs = {} | |||
| if isinstance(loss, dict): | |||
| loss, kwargs = next(iter(loss.items())) | |||
There was a problem hiding this comment.
This is a cool way to split a dict key/value! Does it crap out if there are multiple entries?
There was a problem hiding this comment.
Yeah this was based on a helpful hint from ruff. Itll only return the first key/value even if there are multiple entries.
| data as low res (usually ERA5)""" | ||
| data as low res (usually ERA5) | ||
|
|
||
| NOTE: When initializing the lr_handler it's important to pick a shape |
There was a problem hiding this comment.
Nice, i'd like to see us add more of these "gotchas" directly to the docstrings
github-actions bot
pushed a commit
that referenced
this pull request
Nov 15, 2023
stdev and mean hot fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously computation of multi handler mean and stdev implicitly assumed each handler had roughly the same number of elements. Changed this to include handler weights.