Updating pylint setup for pre-commit #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm all for switching to ruff as our sole linter, if @grantbuster is cool with it. |
|
Independent of moving to ruff or not, shall I move ahead and update pylint anyways? @bnb32 , are the tests failing due to the latest TensorFlow? |
Yes, and yes - let's pin tensorflow to <2.16 |
castelao
added a commit
that referenced
this pull request
Mar 18, 2024
There is something going wrong with TF-2.16 (see PR #198).
castelao
added a commit
that referenced
this pull request
Mar 18, 2024
* fix: np.product() is deprecated Replaced by np.prod() * fix: gaussian_filter() moving to scipy.ndimage The `scipy.ndimage.filters` namespace is deprecated and will be removed in SciPy 2.0.0 * Explicit requirement on numpy and scipy I just noticed that although numpy and scipy are used explicitly in sup3r, there was no explicit dependency on those. The respective minimum versions where defined based on the syntax update in the previous commit. * Holding TensorFlow to <2.16 There is something going wrong with TF-2.16 (see PR #198).
The mirrors-pylint was archived. I'm getting an error with pylint, that hopefully will fix with a newer version.
castelao
force-pushed
the
pylint_precommit_update
branch
from
ae15c16 to
f5cb504
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Mar 18, 2024
* fix: np.product() is deprecated Replaced by np.prod() * fix: gaussian_filter() moving to scipy.ndimage The `scipy.ndimage.filters` namespace is deprecated and will be removed in SciPy 2.0.0 * Explicit requirement on numpy and scipy I just noticed that although numpy and scipy are used explicitly in sup3r, there was no explicit dependency on those. The respective minimum versions where defined based on the syntax update in the previous commit. * Holding TensorFlow to <2.16 There is something going wrong with TF-2.16 (see PR #198).
bnb32
approved these changes
Mar 18, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Mar 18, 2024
The mirrors-pylint was archived. I'm getting an error with pylint, that hopefully will fix with a newer version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mirrors-pylint was archived.
I'm getting an error with pylint, that hopefully will fix with a newer version (or with ruff).