Gb/no regrid #206
Merged
Gb/no regrid #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e index was already sliced so this error is inaccurate
bnb32
reviewed
Apr 8, 2024
| features=self.lr_dh.features, | ||
| max_workers=self.lr_dh.norm_workers) | ||
|
|
||
| if id(self.lr_dh.data) != id(self.lr_data.base): |
There was a problem hiding this comment.
what do you think about putting these id checks in a separate method? clean code has made me wary of using inline comments over good method names/doc strings.
There was a problem hiding this comment.
Just the checks? What about two new methods: _norm_lr() and _norm_hr() with each describing the id issues?
There was a problem hiding this comment.
Yeah "checks" in a royal sense lol. That sounds perfect!
There was a problem hiding this comment.
Makes sense to me! good suggestion.
bnb32
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.