Bnb/nc4 dep removal #210
Merged
Bnb/nc4 dep removal #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnb32
force-pushed
the
bnb/nc4_dep_removal
branch
2 times, most recently
from
f430088 to
04bf1b3
Compare
bnb32
force-pushed
the
bnb/nc4_dep_removal
branch
from
04bf1b3 to
432fe55
Compare
bnb32
force-pushed
the
bnb/nc4_dep_removal
branch
from
432fe55 to
77a6865
Compare
castelao
requested changes
Apr 29, 2024
There was a problem hiding this comment.
A few suggestions. The only point that I think it is important is to define the minimum working version, which would be the smallest between the one you're using now and using at eagle. This information would be important later whenever we decide to update or just moving to kestrel.
bnb32
commented
Apr 30, 2024
…nc4_dep_removal Conflicts: pyproject.toml
github-actions bot
pushed a commit
that referenced
this pull request
May 2, 2024
removed netCDF4 depedency in favor of h5netcdf and cftime. added lr_padded_slice arg to qdm bias transform method. some streamlining for era_downloader
castelao
added a commit
that referenced
this pull request
May 13, 2024
* Testing with Python-3.11 * No direct dependency on google-auth-oauthlib Let's try to remove it as a direct dependency. * It seems to run just fine in 3.11 Thanks to @bnb32 with PR #210 ! * Adding a basic pixi setup Sync dependency tree on OSX and Linux. * And the actual versions * Adding test and doc environment * Update meaningless upgrade on dynamic version of sup3r * Ignoring .pixi * Adding dev environment * dev environment aggregates everyting When developing we test and build documentation. * Updating pixi.lock * Removing netcdf4
github-actions bot
pushed a commit
that referenced
this pull request
May 13, 2024
* Testing with Python-3.11 * No direct dependency on google-auth-oauthlib Let's try to remove it as a direct dependency. * It seems to run just fine in 3.11 Thanks to @bnb32 with PR #210 ! * Adding a basic pixi setup Sync dependency tree on OSX and Linux. * And the actual versions * Adding test and doc environment * Update meaningless upgrade on dynamic version of sup3r * Ignoring .pixi * Adding dev environment * dev environment aggregates everyting When developing we test and build documentation. * Updating pixi.lock * Removing netcdf4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
netCDF4 was only being used in era_downloader and log interpolation. So I've changed this to use xarray with a h5netcdf engine. This allows us to unpin the netCDF dependency.