Explicit keyword argument #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no reason why don't be explicit here, which also gives more freedom in the signature for new methods. This was an issue implementing PresRat, where there was a confusion with lat_lon and time.
bnb32
approved these changes
Jul 2, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jul 2, 2024
There is no reason why don't be explicit here, which also gives more freedom in the signature for new methods. This was an issue implementing PresRat, where there was a confusion with lat_lon and time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The forward pass uses
lat_lonas a positional argument, which caused an error in the PresRat implementation. Is there a good reason to don't be explicit here by using a keyword argument?I split this from #215 to be sure that this is not breaking anything else.