Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bnb/compute on none chunks #233

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Conversation

bnb32
Copy link
Collaborator

@bnb32 bnb32 commented Oct 17, 2024

How about this approach to loading into memory? This mimics the behavior of xr.open_dataset where chunks=None loads into memory as numpy arrays and defaults to dask otherwise.

…dataset() which will default to a dask array manager if chunks is specified and load into memory as numpy arrays in chunks is None.
@bnb32 bnb32 requested a review from grantbuster October 17, 2024 20:48
@bnb32 bnb32 force-pushed the bnb/compute_on_none_chunks branch from 4c8bada to 532eb4d Compare October 21, 2024 19:35
@grantbuster grantbuster merged commit e6f7dc5 into gb/bc_debug Oct 21, 2024
10 checks passed
@grantbuster grantbuster deleted the bnb/compute_on_none_chunks branch October 21, 2024 20:14
@grantbuster grantbuster restored the bnb/compute_on_none_chunks branch October 21, 2024 20:14
@grantbuster grantbuster deleted the bnb/compute_on_none_chunks branch October 21, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants