Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gb/qa fix #248

Merged
merged 3 commits into from
Dec 4, 2024
Merged

Gb/qa fix #248

merged 3 commits into from
Dec 4, 2024

Conversation

grantbuster
Copy link
Member

Three minor fixes:

  1. A function that calls the CLI had mismatched arg order / kwargs
  2. I need "source_features" kwarg for the qa module
  3. The solar preflight check was breaking on GCM data missing leap days but it should only be operating on one day of data at a time so minor change on the check

@grantbuster grantbuster requested a review from bnb32 December 4, 2024 16:53
@grantbuster grantbuster merged commit 095dc7b into main Dec 4, 2024
12 checks passed
@grantbuster grantbuster deleted the gb/qa_fix branch December 4, 2024 21:40
github-actions bot pushed a commit that referenced this pull request Dec 4, 2024
@grantbuster
Merge pull request #248 from NREL/gb/qa_fix
5d6c5dd 
Gb/qa fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnb32 bnb32 bnb32 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grantbuster @bnb32