Skip to content

Commit

Permalink
changes to views for clean up. #935
Browse files Browse the repository at this point in the history
  • Loading branch information
mattbaumann1 committed Apr 28, 2022
1 parent c8da9b1 commit 43b90a7
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 19 deletions.
1 change: 0 additions & 1 deletion app/views/banners/edit.html.haml
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
- content_for(:page_title, "Edit - Banner: #{strip_tags(@banner.body.truncate_words(4))}")


%h1
Edit Banner

Expand Down
1 change: 0 additions & 1 deletion app/views/banners/index.html.haml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

- if current_user.system_admin?
%h3

= yield(:page_title)

= link_to 'Create New Banner', new_banner_path, class: 'button primary'
Expand Down
34 changes: 17 additions & 17 deletions app/views/grant_reviewers/index.html.haml
Original file line number Diff line number Diff line change
Expand Up @@ -37,16 +37,6 @@

.grid-x
.cell.small-5
%h4
Reviewers and Submissions
%p
To remove an assignment, drag the submission from the reviewer's box back to the unassigned submissions box on the right.
%p
Each reviewer may assess up to
= succeed '.' do
= link_to "#{@grant.max_submissions_per_reviewer} #{'submission'.pluralize(@grant.max_submissions_per_reviewer)}", edit_grant_path(@grant, anchor: 'reviewers'), title: 'Change this setting'

.cell.small-5.small-offset-2
%h4
Unassigned Submissions
%p
Expand All @@ -58,21 +48,31 @@
%p
Note: Draft submissions are not reviewable.

.grid-x
#assigned-reviewers.cell.small-5
- if @grant_reviewers.none?
There are no reviewers. Use the form above to define reviewers by their email address.
- else
= render partial: 'reviewers', locals: { grant: @grant, grant_reviewers: @grant_reviewers }
.cell.small-5.small-offset-2
%h4
Reviewers and Submissions
%p
To remove an assignment, drag the submission from the reviewer's box back to the unassigned submissions box on the right.
%p
Each reviewer may assess up to
= succeed '.' do
= link_to "#{@grant.max_submissions_per_reviewer} #{'submission'.pluralize(@grant.max_submissions_per_reviewer)}", edit_grant_path(@grant, anchor: 'reviewers'), title: 'Change this setting'

.gridx.small-5.small-offset-2(data-sticky-container)
.grid-x
.gridx.small-5(data-sticky-container)
#unassigned_submissions.sticky(data-sticky data-top-anchor="assigned-reviewers")
.unassigned_submission_list
- if @unassigned_submissions.none?
There are no completed submissions that need to be assigned.
- else
= render partial: 'unassigned_submissions', locals: { grant: @grant, unassigned_submissions: @unassigned_submissions }

#assigned-reviewers.cell.small-5.small-offset-2
- if @grant_reviewers.none?
There are no reviewers. Use the form above to define reviewers by their email address.
- else
= render partial: 'reviewers', locals: { grant: @grant, grant_reviewers: @grant_reviewers }

:javascript
function downloadJSAtOnload() {
$.ajaxSetup({
Expand Down

0 comments on commit 43b90a7

Please sign in to comment.