Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor banners to use turbo #881

Closed
mattbaumann1 opened this issue Nov 4, 2021 · 2 comments
Closed

refactor banners to use turbo #881

mattbaumann1 opened this issue Nov 4, 2021 · 2 comments
Assignees
Labels
frontend javascript upgrade Upgrade of gems/ruby/rails/etc.

Comments

@mattbaumann1
Copy link
Collaborator

While working on #838 , it was determined that banners would be an easier place to first implement Hotwire and turbo because it is significantly less nested and has less logic and partials than applicants. In this ticket we will add the infrastructure for Hotwire and turbo, which includes starting to use jsbundling-rails and changing css to accommodate the quirks of turbo.

@mattbaumann1
Copy link
Collaborator Author

As of today, banners are working with turbo. We also changed the build of JS to use jsbundling and esbuild. There are aspects of how the different JS libraries and scripts are loading that are still having issues. Select2 has been fixed, but we still need to look at custom in line scripts and will need to find any other examples of broken JS. As of this morning, we are looking at fixing the drag and drop on reviewer assignment.

@mattbaumann1
Copy link
Collaborator Author

Efforts to implement broadcastables for banners were not successful. I talked with multiple people to help with this and I was not able to find a way to satisfactorily implement these. Therefore, I separated the JS changes from the banner efforts and these were incorporated in #933. This ticket will be paused at this point. If we return to this issue, we will open in a new ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend javascript upgrade Upgrade of gems/ruby/rails/etc.
Projects
None yet
Development

No branches or pull requests

2 participants