Don't try to change enabled status of current user #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The currently logged-in user can't change their own enabled status, however on clicking Save in the user edit dialog the changeUserEnabledStatus method is still called. Because of this, on server side a ForbiddenException is thrown and the dialog window does not close. With this commit a check is added not to call the method.
mafasva
approved these changes
Jul 31, 2024
ramueSVA
merged commit 4a94679
into
NUM-Forschungsdatenplattform:develop
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The currently logged-in user can't change their own enabled status, however on clicking Save in the user edit dialog the changeUserEnabledStatus method is still called. Because of this, on server side a ForbiddenException is thrown and the dialog window does not close. With this commit a check is added not to call the method.