[Refactor] optimize the assign and find_or_insert by new algorithm #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation previewhttps://nvidia-merlin.github.io/HierarchicalKV/review/pr-121 |
jiashuy
reviewed
May 6, 2023
| int key_pos = -1; | ||
| size_t key_idx = t / TILE_SIZE; | ||
| int local_size = 0; | ||
| const size_t key_idx = t / TILE_SIZE; |
There was a problem hiding this comment.
In general case, the KV number in a batch is less than 2^32. If not, there will be too many keys in our table.
So can we use the uint32_t instead of size_t? The same as the variable in the function of find_key_position .
There was a problem hiding this comment.
Make sense, will do some optimization in a seperate PR.
jiashuy
approved these changes
May 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.