template the erase_if and export_batch_if API #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation previewhttps://nvidia-merlin.github.io/HierarchicalKV/review/pr-132 |
Lifann
force-pushed
the
templatorize-api-with-pred
branch
5 times, most recently
from
5c9d1f3 to
a4e478d
Compare
Lifann
changed the title
|
/blossom-ci |
|
Hi @Lifann, please drop the commit in the head and rebase on the master. Thank you! |
rhdong
force-pushed
the
templatorize-api-with-pred
branch
from
a4e478d to
58d7484
Compare
|
/blossom-ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
APIs like
erase_ifandexport_batch_ifuse function pointer to enable multiple policies to match the keys in table. But It can easily lead to issues like memory access error, misaligned address(#125), performance downgrade.This PR change the APIs with approach of Templating which avoid issues above.