Update to reflect new default benchmark settings #142
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that this commit 921e9b8 updates the benchmark numbers but not the settings for the new largest KV.
i.e.
dim = 64, capacity = 1024 Million-KV, HBM = 56 GB, HMEM = 200 GB
in 921e9b8#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5L159should now be
dim = 64, capacity = 512 Million-KV, HBM = 32 GB, HMEM = 96 GB
My numbers with the new benchmark defaults: