[Feat] make allocator templated #144
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation previewhttps://nvidia-merlin.github.io/HierarchicalKV/review/pr-144 |
|
/blossom-ci |
Lifann
reviewed
Jun 22, 2023
| @@ -148,14 +149,15 @@ static constexpr auto& thrust_par = thrust::cuda::par; | |||
| * | |||
| */ | |||
| template <typename K, typename V, typename S = uint64_t, | |||
| typename ArchTag = Sm80> | |||
| typename ArchTag = Sm80, typename Allocator = DefaultAllocator> | |||
There was a problem hiding this comment.
In some case like tensorflow, the allocator is created before merlin::HashTable construction. So It would be better to allow assignment from outside allocator, whom meeting the requirements of interface internal.
There was a problem hiding this comment.
Sure, I though of this, please move to this one: #145
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.