Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] fixup the call to tlp_v2_upsert_and_evict due to error on cuda11.2. #159

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

jiashuy
Copy link
Collaborator

@jiashuy jiashuy commented Aug 15, 2023

[Fix] fixup the call to tlp_v2_upsert_and_evict due to error on cuda11.2.

@github-actions
Copy link

@jiashuy jiashuy changed the title [Fix] cancel function call to tlp_v2_upsert_and_evict due to illegal address. [Fix] fixup the call to tlp_v2_upsert_and_evict due to error on cuda11.2. Aug 15, 2023
README.md Outdated
| 0.50 | 1.151 | 2.535 | 1.691 | 1.927 | 4.127 | 1.799 | 1.071 |
| 0.75 | 0.999 | 2.538 | 0.668 | 0.864 | 1.927 | 1.293 | 1.026 |
| 1.00 | 0.364 | 2.559 | 0.370 | 0.498 | 0.929 | 0.392 | 0.505 |
| 0.50 | 1.157 | 2.600 | 1.701 | 1.929 | 4.135 | 1.807 | 1.077 |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to update benchmark.

@@ -17,6 +17,7 @@
#pragma once

#include <cooperative_groups.h>
#include <cuda_runtime_api.h>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No needed.

@rhdong
Copy link
Member

rhdong commented Aug 15, 2023

/blossom-ci

Copy link
Member

@rhdong rhdong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhdong
Copy link
Member

rhdong commented Aug 15, 2023

/blossom-ci

@rhdong rhdong merged commit 0e22922 into NVIDIA-Merlin:master Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants