[Fix] make thrust temp memory allocation managed by HKV allocator. #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhdong
force-pushed
the
rhdong/thrust-allocator
branch
from
11a1c7d to
3b8ed85
Compare
|
/blossom-ci |
Documentation previewhttps://nvidia-merlin.github.io/HierarchicalKV/review/pr-178 |
rhdong
force-pushed
the
rhdong/thrust-allocator
branch
2 times, most recently
from
1d0dc9c to
30bef74
Compare
- Refactoring: clean the warning on low version of CUDA
rhdong
force-pushed
the
rhdong/thrust-allocator
branch
from
30bef74 to
5dfba55
Compare
|
/blossom-ci |
rhdong
commented
Oct 24, 2023
| @@ -1146,6 +1146,7 @@ struct KernelSelector_Upsert { | |||
| } | |||
| }; | |||
|
|
|||
| #if defined(CUDART_VERSION) && (CUDART_VERSION >= 11030) | |||
There was a problem hiding this comment.
Hi @jiashuy, I cleaned some TLPv2 warnings we discussed before. Please help review and confirm. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.