Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[opt] Allocate hbm uniformly for buckets to avoid fragmentation. #181

Merged
merged 1 commit into from
Dec 7, 2023
Merged

[opt] Allocate hbm uniformly for buckets to avoid fragmentation. #181

merged 1 commit into from
Dec 7, 2023

Conversation

LinGeLin
Copy link
Collaborator

@LinGeLin LinGeLin commented Dec 1, 2023

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2023

Documentation preview

https://nvidia-merlin.github.io/HierarchicalKV/review/pr-181

@LinGeLin LinGeLin requested review from rhdong and jiashuy December 1, 2023 10:25
@rhdong
Copy link
Member

rhdong commented Dec 6, 2023

/blossom-ci

rhdong
rhdong reviewed Dec 6, 2023
View reviewed changes
include/merlin/types.cuh
@@ -161,6 +162,7 @@ struct Table {
int slots_number = 0; // unused
int device_id = 0; // Device id
int tile_size;
std::vector<uint8_t*> buckets_address;
Copy link
Member

@rhdong rhdong Dec 6, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jiashuy, Here, it looks like we need to unify the uint8_t into D defined in the types.h. We can do refactoring in a new PR instead of this PR.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get it.

rhdong
rhdong approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@rhdong rhdong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jiashuy
jiashuy approved these changes Dec 7, 2023 •
edited
Loading
View reviewed changes
jiashuy
jiashuy approved these changes Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@jiashuy jiashuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhdong rhdong merged commit 770be38 into NVIDIA-Merlin:master Dec 7, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiashuy jiashuy jiashuy approved these changes

@rhdong rhdong rhdong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LinGeLin @rhdong @jiashuy