avoid mixed usage of Array<T, N> and T[N] when passing to template function #1475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!build --diff --diff-bench |
liqiangxl
force-pushed
the
llu/aliasing_different_types
branch
from
2d1225f to
3adc823
Compare
liqiangxl
changed the title
|
!build --diff --diff-bench |
liqiangxl
force-pushed
the
llu/aliasing_different_types
branch
from
d4183d6 to
6fc67f9
Compare
liqiangxl
force-pushed
the
llu/aliasing_different_types
branch
from
2a8fabd to
7905dde
Compare
liqiangxl
changed the title
|
!build --diff --diff-bench |
|
codediff in matmul cases are caused by |
zasdfgbnm
approved these changes
Feb 22, 2024
csrc/codegen.cpp
Outdated
| // array. This avoid the type mismatch in template functions when one of the | ||
| // arguments is an aligned array (Array<T,N>) while the other is a regular | ||
| // array T[N]. | ||
| std::string genVarForTemplateFunction(Val* v) { |
There was a problem hiding this comment.
Should this be named something like maybeConvertAlignedArrayToRawArray?
There was a problem hiding this comment.
I rename to genVariableNameConvertAlignedArray to reflect its two functions: (1) call genVariableName and (2) ConvertAlignedArrayToRawArray
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1470
In the generated code of the case posted in the issue page:
nvfuser_index_t T5[4]is aliased asArray<float, 4> T9.float T4[4]is aliased asauto& T10 = T4.Then T9 and T10 are used to call
welfordGroupOuterand causes a compilation error due to type mismatch: T9 is a custom array type, while T10 is a native float array.Fix: always pass the regular array of registers to template function.