Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression in slice #758

Merged
merged 2 commits into from
Oct 4, 2024
Merged

Fix regression in slice #758

merged 2 commits into from
Oct 4, 2024

Conversation

cliffburdick
Copy link
Collaborator

No description provided.

@cliffburdick
Copy link
Collaborator Author

/build

@cliffburdick cliffburdick requested a review from luitjens October 3, 2024 21:41
luitjens
luitjens approved these changes Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@luitjens luitjens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a unit test to catch this bug.

@cliffburdick
Copy link
Collaborator Author

/build

@cliffburdick
Copy link
Collaborator Author

/build

@cliffburdick cliffburdick merged commit c7ff700 into main Oct 4, 2024
1 check passed
@cliffburdick cliffburdick deleted the slice_fix branch October 4, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luitjens luitjens luitjens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cliffburdick @luitjens