Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: session start fixture correctly handles being launched by mpirun #486

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

terrykong
Copy link
Collaborator

What does this PR do ?

This fix was only in dev, so cherry-picking it into main

Changelog

  • Please update the CHANGELOG.md under next version with high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

Checklist when contributing a new algorithm

  • Does the trainer resume and restore model state all states?
  • Does the trainer support all parallelism techniques(PP, TP, DP)?
  • Does the trainer support max_steps=-1 and validation?
  • Does the trainer only call APIs defined in alignable_interface.py?
  • Does the trainer have proper logging?

Additional Information

  • Related to # (issue)

@terrykong terrykong requested a review from ko3n1g January 17, 2025 22:25
@terrykong terrykong added the Run CICD Set + un-set to retrigger label Jan 17, 2025
@terrykong terrykong enabled auto-merge (squash) January 17, 2025 22:26
@terrykong terrykong merged commit 9512ee8 into main Jan 21, 2025
20 checks passed
@terrykong terrykong deleted the tk/mpi-unit-test-fix branch January 21, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Run CICD Set + un-set to retrigger
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants