Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix linking of reinforce from index and add it to support table #489

Merged
merged 3 commits into from
Jan 27, 2025

Conversation

terrykong
Copy link
Collaborator

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Changelog

  • Please update the CHANGELOG.md under next version with high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

Checklist when contributing a new algorithm

  • Does the trainer resume and restore model state all states?
  • Does the trainer support all parallelism techniques(PP, TP, DP)?
  • Does the trainer support max_steps=-1 and validation?
  • Does the trainer only call APIs defined in alignable_interface.py?
  • Does the trainer have proper logging?

Additional Information

  • Related to # (issue)

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 23, 2025
@terrykong terrykong changed the title doc: fix linking of reinforce from index and add it to support table docs: fix linking of reinforce from index and add it to support table Jan 23, 2025
Signed-off-by: Terry Kong <[email protected]>
@ko3n1g ko3n1g enabled auto-merge (squash) January 27, 2025 11:01
@ko3n1g ko3n1g disabled auto-merge January 27, 2025 11:03
@ko3n1g ko3n1g merged commit 82f0215 into main Jan 27, 2025
13 checks passed
@ko3n1g ko3n1g deleted the tk/reinforce-doc-fix branch January 27, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Skip CICD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants