Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code style and actions changes #145

Merged
merged 26 commits into from
Oct 19, 2023
Merged

Code style and actions changes #145

merged 26 commits into from
Oct 19, 2023

Conversation

dimapihtar
Copy link
Collaborator

PR changes:

  1. Reformatted all code base using black (in order to fix code style).
  2. Added unit tests for launcher and auto configurator.
  3. Added github actions in order to run code style check and unit tests when pushing changes to master branch.

dimapihtar and others added 26 commits October 12, 2023 04:02
@dimapihtar
add action
5a82aa2 
Signed-off-by: dimapihtar <[email protected]>
@dimapihtar
add unit_tests
4098014 
Signed-off-by: dimapihtar <[email protected]>
@dimapihtar
Merge pull request #143 from NVIDIA/dpykhtar/unit_tests_add
6eace07 
add unit_tests
@dimapihtar
run unit_tests
90b1751 
Signed-off-by: dimapihtar <[email protected]>
@dimapihtar
action changes
51d0c34 
Signed-off-by: dimapihtar <[email protected]>
@dimapihtar
action changes
04819cb 
Signed-off-by: dimapihtar <[email protected]>
@dimapihtar
action changes
358823d 
Signed-off-by: dimapihtar <[email protected]>
@dimapihtar
actions fix
5e022d8 
Signed-off-by: dimapihtar <[email protected]>
@dimapihtar
actions fix
7437dfd 
Signed-off-by: dimapihtar <[email protected]>
@dimapihtar
actions fix
a0eaec7 
Signed-off-by: dimapihtar <[email protected]>
@dimapihtar
actions changes
e3fe76b 
Signed-off-by: dimapihtar <[email protected]>
@dimapihtar
action fix
97e5008 
Signed-off-by: dimapihtar <[email protected]>
@dimapihtar
actions fix
570858d 
Signed-off-by: dimapihtar <[email protected]>
@dimapihtar
actions fix
b8fa54c 
Signed-off-by: dimapihtar <[email protected]>
@dimapihtar
action fix
3c720bb 
Signed-off-by: dimapihtar <[email protected]>
@dimapihtar
run tests
c2caffe 
Signed-off-by: dimapihtar <[email protected]>
@dimapihtar
change action
028c7e9 
Signed-off-by: dimapihtar <[email protected]>
@dimapihtar
test commit
cb5ddc1 
Signed-off-by: dimapihtar <[email protected]>
@dimapihtar
change action
8b58a04 
Signed-off-by: dimapihtar <[email protected]>
@dimapihtar
add more tests
8187bb7 
Signed-off-by: dimapihtar <[email protected]>
@dimapihtar
Merge branch 'dpykhtar/unit_tests' into dpykhtar/test_branch
c97de3b
@dimapihtar
reformat code style
ae42350 
Signed-off-by: dimapihtar <[email protected]>
@dimapihtar
fix imports
7f11e47 
Signed-off-by: dimapihtar <[email protected]>
@dimapihtar
fix code style
e24aeee 
Signed-off-by: dimapihtar <[email protected]>
@dimapihtar
Merge pull request #144 from NVIDIA/dpykhtar/test_branch
812dd54 
code styling changes
@dimapihtar
change actions destination
4487ba1 
Signed-off-by: dimapihtar <[email protected]>
@dimapihtar dimapihtar requested a review from ericharper October 12, 2023 17:30
ericharper
ericharper approved these changes Oct 18, 2023
View reviewed changes
Copy link
Collaborator

@ericharper ericharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@dimapihtar dimapihtar merged commit 5ec9834 into master Oct 19, 2023
3 checks passed
@dimapihtar dimapihtar deleted the dpykhtar/unit_tests branch October 19, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericharper ericharper ericharper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dimapihtar @ericharper