Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Librispeech all, mini support #72

Merged
merged 8 commits into from
Sep 27, 2024
Merged

Librispeech all, mini support #72

merged 8 commits into from
Sep 27, 2024

Conversation

Alcray
Copy link
Collaborator

@Alcray Alcray commented Jul 3, 2024

No description provided.

Copy link
Collaborator

@erastorgueva-nv erastorgueva-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. Please address my comments, and then should be good to merge once the CI tests are fixed in the other PR?

dataset_configs/english/librispeech/config.yaml Outdated Show resolved Hide resolved
docs/src/sdp/existing_configs.rst Outdated Show resolved Hide resolved
docs/src/sdp/existing_configs.rst Outdated Show resolved Hide resolved
docs/src/sdp/existing_configs.rst Outdated Show resolved Hide resolved
@Alcray Alcray force-pushed the librispeechAllMini branch from c6e4649 to a0ea309 Compare July 25, 2024 11:40
@Alcray Alcray force-pushed the librispeechAllMini branch from 8350f61 to a2b8aff Compare September 4, 2024 07:57
dataset_configs/english/librispeech/all.yaml Outdated Show resolved Hide resolved
dataset_configs/english/librispeech/config.yaml Outdated Show resolved Hide resolved
tests/test_cfg_end_to_end_tests.py Outdated Show resolved Hide resolved
Signed-off-by: Alexan <[email protected]>
Signed-off-by: Alexan <[email protected]>
@erastorgueva-nv erastorgueva-nv merged commit aec62fa into main Sep 27, 2024
5 of 6 checks passed
@erastorgueva-nv erastorgueva-nv deleted the librispeechAllMini branch September 27, 2024 18:34
monica-sekoyan pushed a commit to monica-sekoyan/NeMo-speech-data-processor that referenced this pull request Oct 5, 2024
* addded support for all and mini configs of librispeech. removed multiple splits merge feature

Signed-off-by: Alexan <[email protected]>

* Solved comments

Signed-off-by: Alexan <[email protected]>

* Test fixes

Signed-off-by: Alexan <[email protected]>

* test fix of librispeech

Signed-off-by: Alexan <[email protected]>

* Remove sdp.egg-info directory

Signed-off-by: Alexan <[email protected]>

* test fix

Signed-off-by: Alexan <[email protected]>

* Fix of docs

Signed-off-by: Alexan <[email protected]>

* fix of requirements/main.txt

Signed-off-by: Alexan <[email protected]>

---------

Signed-off-by: Alexan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants