Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future Implementations for classes - Measure, Money and Date #257

Open
wants to merge 288 commits into
base: main
Choose a base branch
from

Conversation

ngachchi
Copy link
Contributor

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Before your PR is "Ready for review"

Pre checks:

  • Have you signed your commits? Use git commit -s to sign.
  • Do all unittests finish successfully before sending PR?
    1. pytest or (if your machine does not have GPU) pytest --cpu from the root folder (given you marked your test cases accordingly @pytest.mark.run_only_on('CPU')).
    2. Sparrowhawk tests bash tools/text_processing_deployment/export_grammars.sh --MODE=test ...
  • If you are adding a new feature: Have you added test cases for both pytest and Sparrowhawk here.
  • Have you added __init__.py for every folder and subfolder, including data folder which has .TSV files?
  • Have you followed codeQL results and removed unused variables and imports (report is at the bottom of the PR in github review box) ?
  • Have you added the correct license header Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved. to all newly added Python files?
  • If you copied nemo_text_processing/text_normalization/en/graph_utils.py your header's second line should be Copyright 2015 and onwards Google, Inc.. See an example here.
  • Remove import guards (try import: ... except: ...) if not already done.
  • If you added a new language or a new feature please update the NeMo documentation (lives in different repo).
  • Have you added your language support to tools/text_processing_deployment/pynini_export.py.

PR Type:

  • New Feature
  • Bugfix
  • Documentation
  • Test

If you haven't finished some of the above items you can still open "Draft" PR.

ngachchi and others added 30 commits December 3, 2024 10:16
Signed-off-by: Simon Zuberek <[email protected]>
* ja tn

Signed-off-by: Alex Cui <[email protected]>

* adding ja

Signed-off-by: Alex Cui <[email protected]>

* removing

Signed-off-by: Alex Cui <[email protected]>

* updated tests

Signed-off-by: Alex Cui <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* addressing comment

Signed-off-by: Alex Cui <[email protected]>

* addressing ci

Signed-off-by: Alex Cui <[email protected]>

* addressing ci

Signed-off-by: Alex Cui <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* addresing comment

Signed-off-by: Alex Cui <[email protected]>

* removing

Signed-off-by: Alex Cui <[email protected]>

* adresing comment

Signed-off-by: Alex Cui <[email protected]>

* removing unused import

Signed-off-by: Alex Cui <[email protected]>

* addressing comment

Signed-off-by: Alex Cui <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* addressing comment;

Signed-off-by: Alex Cui <[email protected]>

* addressing comment

Signed-off-by: Alex Cui <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* date for ja

Signed-off-by: Alex Cui <[email protected]>

* addresing comment

Signed-off-by: Alex Cui <[email protected]>

* addressing comment

Signed-off-by: Alex Cui <[email protected]>

* jenkins

Signed-off-by: Alex Cui <[email protected]>

* addresing comment

Signed-off-by: Alex Cui <[email protected]>

* addressing comment

Signed-off-by: Alex Cui <[email protected]>

* typo

Signed-off-by: Alex Cui <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* adressing comment

Signed-off-by: Alex Cui <[email protected]>

* addressing comment

Signed-off-by: Alex Cui <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* ci

Signed-off-by: Alex Cui <[email protected]>

---------

Signed-off-by: Alex Cui <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Namrata Gachchi <[email protected]>
* Fixes issue 228

Signed-off-by: Simon Zuberek <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fixes issue 228

Signed-off-by: Simon Zuberek <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Expands Whitelist and removes redundant [0-9]+-[A-Za-z] (and in reverse) pattern matching from ELECTRONIC

Signed-off-by: Simon Zuberek <[email protected]>

* Updates the cache

Signed-off-by: Simon Zuberek <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Removes unused imports and variables

Signed-off-by: Simon Zuberek <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Removes redundant abbreviation mappings

Signed-off-by: Simon Zuberek <[email protected]>

* Updates the cache

Signed-off-by: Simon Zuberek <[email protected]>

---------

Signed-off-by: Simon Zuberek <[email protected]>
Co-authored-by: Simon Zuberek <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Namrata Gachchi <[email protected]>
…e, Money and Measure (NVIDIA#223)

* Hindi ITN Support for Cardinal, Decimal, Ordinal, Fraction, Date, Time

Signed-off-by: Tarushi V <[email protected]>

* Cleanup

Signed-off-by: Tarushi V <[email protected]>

* Cleanup

Signed-off-by: Tarushi V <[email protected]>

* Committing all changes made

Signed-off-by: Tarushi V <[email protected]>

* Updated date.py and added more test cases to cardinal for improved accuracy

Signed-off-by: Tarushi V <[email protected]>

* Updated date.py

Signed-off-by: Tarushi V <[email protected]>

* Added hi to Jenkins and cleanup

Signed-off-by: Tarushi V <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Changes and cleanup based on feedback

Signed-off-by: Tarushi V <[email protected]>

* Changes and cleanup based on feedback

Signed-off-by: Tarushi V <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Resolved conflicts

Signed-off-by: Tarushi V <[email protected]>

* Committing code for measure.py

Signed-off-by: Tarushi V <[email protected]>

* Cleanup

Signed-off-by: Tarushi V <[email protected]>

* Cleanup

Signed-off-by: Tarushi V <[email protected]>

* changes to run_evaluate.py

Signed-off-by: Tarushi V <[email protected]>

* Hindi ITN for money.py

Signed-off-by: Tarushi V <[email protected]>

* Changes and cleanup

Signed-off-by: Tarushi V <[email protected]>

* Cleanup

Signed-off-by: Tarushi V <[email protected]>

* Cleanup

Signed-off-by: Tarushi V <[email protected]>

* Cleanup date verbalizer

Signed-off-by: Tarushi V <[email protected]>

* Cleanup

Signed-off-by: Tarushi V <[email protected]>

* Cleanup

Signed-off-by: Tarushi V <[email protected]>

* Cleanup

Signed-off-by: Tarushi V <[email protected]>

* Cleanup

Signed-off-by: Tarushi V <[email protected]>

* Cleanup

Signed-off-by: Tarushi V <[email protected]>

* Cleanup

Signed-off-by: Tarushi V <[email protected]>

* Cleanup

Signed-off-by: Tarushi V <[email protected]>

* pushing .gitignore file from main branch

Signed-off-by: Tarushi V <[email protected]>

---------

Signed-off-by: Tarushi V <[email protected]>
Signed-off-by: tarushi2k2 <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Namrata Gachchi <[email protected]>
for more information, see https://pre-commit.ci

Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Namrata Gachchi <[email protected]>
ngachchi and others added 30 commits December 17, 2024 12:11
Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Simon Zuberek <[email protected]>
Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Simon Zuberek <[email protected]>
Signed-off-by: Namrata Gachchi <[email protected]>
* Fix space issue with ZH ITN

Signed-off-by: Anand Joseph <[email protected]>

* Update Jenkinsfile

Update FST paths

Signed-off-by: anand-nv <[email protected]>

---------

Signed-off-by: Anand Joseph <[email protected]>
Signed-off-by: anand-nv <[email protected]>
Signed-off-by: Simon Zuberek <[email protected]>
Co-authored-by: Anand Joseph <[email protected]>
Co-authored-by: anand-nv <[email protected]>
Signed-off-by: Namrata Gachchi <[email protected]>
* contributing update

Signed-off-by: tbartley94 <[email protected]>

* adding edits

Signed-off-by: tbartley94 <[email protected]>

* spelling

Signed-off-by: tbartley94 <[email protected]>

---------

Signed-off-by: tbartley94 <[email protected]>
Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Namrata Gachchi <[email protected]>
* Addition of whitelist and word classes

Signed-off-by: Tarushi V <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Updation of Jenkins date

Signed-off-by: Tarushi V <[email protected]>

* Cleanup

Signed-off-by: Tarushi V <[email protected]>

* Updation

Signed-off-by: Tarushi V <[email protected]>

* Updation

Signed-off-by: Tarushi V <[email protected]>

---------

Signed-off-by: Tarushi V <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Namrata Gachchi <[email protected]>
* Addition of whitelist and word classes

Signed-off-by: Tarushi V <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Updation of Jenkins date

Signed-off-by: Tarushi V <[email protected]>

* Cleanup

Signed-off-by: Tarushi V <[email protected]>

* Updation

Signed-off-by: Tarushi V <[email protected]>

* Updation

Signed-off-by: Tarushi V <[email protected]>

---------

Signed-off-by: Tarushi V <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Namrata Gachchi <[email protected]>
* Addition of whitelist and word classes

Signed-off-by: Tarushi V <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Updation of Jenkins date

Signed-off-by: Tarushi V <[email protected]>

* Cleanup

Signed-off-by: Tarushi V <[email protected]>

* Updation

Signed-off-by: Tarushi V <[email protected]>

* Updation

Signed-off-by: Tarushi V <[email protected]>

---------

Signed-off-by: Tarushi V <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Namrata Gachchi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.