-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Future Implementations for classes - Measure, Money and Date #257
Open
ngachchi
wants to merge
288
commits into
NVIDIA:main
Choose a base branch
from
ngachchi:hi_tn
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+290
−138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Simon Zuberek <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Simon Zuberek <[email protected]>
Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Namrata Gachchi <[email protected]>
for more information, see https://pre-commit.ci
* ja tn Signed-off-by: Alex Cui <[email protected]> * adding ja Signed-off-by: Alex Cui <[email protected]> * removing Signed-off-by: Alex Cui <[email protected]> * updated tests Signed-off-by: Alex Cui <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * addressing comment Signed-off-by: Alex Cui <[email protected]> * addressing ci Signed-off-by: Alex Cui <[email protected]> * addressing ci Signed-off-by: Alex Cui <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * addresing comment Signed-off-by: Alex Cui <[email protected]> * removing Signed-off-by: Alex Cui <[email protected]> * adresing comment Signed-off-by: Alex Cui <[email protected]> * removing unused import Signed-off-by: Alex Cui <[email protected]> * addressing comment Signed-off-by: Alex Cui <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * addressing comment; Signed-off-by: Alex Cui <[email protected]> * addressing comment Signed-off-by: Alex Cui <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * date for ja Signed-off-by: Alex Cui <[email protected]> * addresing comment Signed-off-by: Alex Cui <[email protected]> * addressing comment Signed-off-by: Alex Cui <[email protected]> * jenkins Signed-off-by: Alex Cui <[email protected]> * addresing comment Signed-off-by: Alex Cui <[email protected]> * addressing comment Signed-off-by: Alex Cui <[email protected]> * typo Signed-off-by: Alex Cui <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * adressing comment Signed-off-by: Alex Cui <[email protected]> * addressing comment Signed-off-by: Alex Cui <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * ci Signed-off-by: Alex Cui <[email protected]> --------- Signed-off-by: Alex Cui <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Namrata Gachchi <[email protected]>
* Fixes issue 228 Signed-off-by: Simon Zuberek <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fixes issue 228 Signed-off-by: Simon Zuberek <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Expands Whitelist and removes redundant [0-9]+-[A-Za-z] (and in reverse) pattern matching from ELECTRONIC Signed-off-by: Simon Zuberek <[email protected]> * Updates the cache Signed-off-by: Simon Zuberek <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Removes unused imports and variables Signed-off-by: Simon Zuberek <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Removes redundant abbreviation mappings Signed-off-by: Simon Zuberek <[email protected]> * Updates the cache Signed-off-by: Simon Zuberek <[email protected]> --------- Signed-off-by: Simon Zuberek <[email protected]> Co-authored-by: Simon Zuberek <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Namrata Gachchi <[email protected]>
for more information, see https://pre-commit.ci Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Namrata Gachchi <[email protected]>
for more information, see https://pre-commit.ci Signed-off-by: Namrata Gachchi <[email protected]>
…g the file opened Signed-off-by: Namrata Gachchi <[email protected]>
for more information, see https://pre-commit.ci
…e, Money and Measure (NVIDIA#223) * Hindi ITN Support for Cardinal, Decimal, Ordinal, Fraction, Date, Time Signed-off-by: Tarushi V <[email protected]> * Cleanup Signed-off-by: Tarushi V <[email protected]> * Cleanup Signed-off-by: Tarushi V <[email protected]> * Committing all changes made Signed-off-by: Tarushi V <[email protected]> * Updated date.py and added more test cases to cardinal for improved accuracy Signed-off-by: Tarushi V <[email protected]> * Updated date.py Signed-off-by: Tarushi V <[email protected]> * Added hi to Jenkins and cleanup Signed-off-by: Tarushi V <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Changes and cleanup based on feedback Signed-off-by: Tarushi V <[email protected]> * Changes and cleanup based on feedback Signed-off-by: Tarushi V <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Resolved conflicts Signed-off-by: Tarushi V <[email protected]> * Committing code for measure.py Signed-off-by: Tarushi V <[email protected]> * Cleanup Signed-off-by: Tarushi V <[email protected]> * Cleanup Signed-off-by: Tarushi V <[email protected]> * changes to run_evaluate.py Signed-off-by: Tarushi V <[email protected]> * Hindi ITN for money.py Signed-off-by: Tarushi V <[email protected]> * Changes and cleanup Signed-off-by: Tarushi V <[email protected]> * Cleanup Signed-off-by: Tarushi V <[email protected]> * Cleanup Signed-off-by: Tarushi V <[email protected]> * Cleanup date verbalizer Signed-off-by: Tarushi V <[email protected]> * Cleanup Signed-off-by: Tarushi V <[email protected]> * Cleanup Signed-off-by: Tarushi V <[email protected]> * Cleanup Signed-off-by: Tarushi V <[email protected]> * Cleanup Signed-off-by: Tarushi V <[email protected]> * Cleanup Signed-off-by: Tarushi V <[email protected]> * Cleanup Signed-off-by: Tarushi V <[email protected]> * Cleanup Signed-off-by: Tarushi V <[email protected]> * pushing .gitignore file from main branch Signed-off-by: Tarushi V <[email protected]> --------- Signed-off-by: Tarushi V <[email protected]> Signed-off-by: tarushi2k2 <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Namrata Gachchi <[email protected]>
for more information, see https://pre-commit.ci Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Namrata Gachchi <[email protected]>
…d word file Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Namrata Gachchi <[email protected]>
for more information, see https://pre-commit.ci Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Namrata Gachchi <[email protected]>
for more information, see https://pre-commit.ci Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Simon Zuberek <[email protected]> Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Simon Zuberek <[email protected]> Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Namrata Gachchi <[email protected]>
for more information, see https://pre-commit.ci Signed-off-by: Namrata Gachchi <[email protected]>
* Fix space issue with ZH ITN Signed-off-by: Anand Joseph <[email protected]> * Update Jenkinsfile Update FST paths Signed-off-by: anand-nv <[email protected]> --------- Signed-off-by: Anand Joseph <[email protected]> Signed-off-by: anand-nv <[email protected]> Signed-off-by: Simon Zuberek <[email protected]> Co-authored-by: Anand Joseph <[email protected]> Co-authored-by: anand-nv <[email protected]> Signed-off-by: Namrata Gachchi <[email protected]>
* contributing update Signed-off-by: tbartley94 <[email protected]> * adding edits Signed-off-by: tbartley94 <[email protected]> * spelling Signed-off-by: tbartley94 <[email protected]> --------- Signed-off-by: tbartley94 <[email protected]> Signed-off-by: Namrata Gachchi <[email protected]>
into hi_tn Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Namrata Gachchi <[email protected]>
* Addition of whitelist and word classes Signed-off-by: Tarushi V <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Updation of Jenkins date Signed-off-by: Tarushi V <[email protected]> * Cleanup Signed-off-by: Tarushi V <[email protected]> * Updation Signed-off-by: Tarushi V <[email protected]> * Updation Signed-off-by: Tarushi V <[email protected]> --------- Signed-off-by: Tarushi V <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Namrata Gachchi <[email protected]>
* Addition of whitelist and word classes Signed-off-by: Tarushi V <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Updation of Jenkins date Signed-off-by: Tarushi V <[email protected]> * Cleanup Signed-off-by: Tarushi V <[email protected]> * Updation Signed-off-by: Tarushi V <[email protected]> * Updation Signed-off-by: Tarushi V <[email protected]> --------- Signed-off-by: Tarushi V <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Namrata Gachchi <[email protected]>
* Addition of whitelist and word classes Signed-off-by: Tarushi V <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Updation of Jenkins date Signed-off-by: Tarushi V <[email protected]> * Cleanup Signed-off-by: Tarushi V <[email protected]> * Updation Signed-off-by: Tarushi V <[email protected]> * Updation Signed-off-by: Tarushi V <[email protected]> --------- Signed-off-by: Tarushi V <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Namrata Gachchi <[email protected]>
for more information, see https://pre-commit.ci Signed-off-by: Namrata Gachchi <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Namrata Gachchi <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Namrata Gachchi <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Namrata Gachchi <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Namrata Gachchi <[email protected]>
Signed-off-by: Namrata Gachchi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Before your PR is "Ready for review"
Pre checks:
git commit -s
to sign.pytest
or (if your machine does not have GPU)pytest --cpu
from the root folder (given you marked your test cases accordingly@pytest.mark.run_only_on('CPU')
).bash tools/text_processing_deployment/export_grammars.sh --MODE=test ...
pytest
and Sparrowhawk here.__init__.py
for every folder and subfolder, includingdata
folder which has .TSV files?Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
to all newly added Python files?Copyright 2015 and onwards Google, Inc.
. See an example here.try import: ... except: ...
) if not already done.PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.