Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support exporting Nemotron-340B for TensorRT-LLM #11015

Merged

Conversation

jinyangyuan-nvidia
Copy link
Contributor

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@jinyangyuan-nvidia jinyangyuan-nvidia force-pushed the fix_convert_nemotron_340b branch from 73d1a52 to 83299cc Compare October 24, 2024 02:48
@juney-nvidia
Copy link

@oyilmaz-nvidia Hi Onur, can you help review this PR?
In TRT-LLM 0.14 release, we are working to prepare documentation for multi-node deployment and we want to use Nemotron as an example. Without this fix, we cannot run through Nemotron on multi-node.

@meatybobby
Copy link
Collaborator

It seems the changes in nemo/export/trt_llm/converter/model_converter.py is not necessary. I tested parallel_embedding still works without the changes. Could we remove the change on this file?

@meatybobby meatybobby enabled auto-merge (squash) October 29, 2024 16:58
@oyilmaz-nvidia oyilmaz-nvidia enabled auto-merge (squash) October 29, 2024 20:01
@oyilmaz-nvidia oyilmaz-nvidia merged commit bad4bfe into NVIDIA:main Oct 31, 2024
154 of 155 checks passed
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 5, 2024
Signed-off-by: Jinyang Yuan <[email protected]>
Co-authored-by: Jinyang Yuan <[email protected]>
Co-authored-by: meatybobby <[email protected]>
Signed-off-by: Hainan Xu <[email protected]>
lilyw97 pushed a commit to lilyw97/NeMo that referenced this pull request Nov 13, 2024
Signed-off-by: Jinyang Yuan <[email protected]>
Co-authored-by: Jinyang Yuan <[email protected]>
Co-authored-by: meatybobby <[email protected]>
HuiyingLi pushed a commit to HuiyingLi/NeMo that referenced this pull request Nov 15, 2024
Signed-off-by: Jinyang Yuan <[email protected]>
Co-authored-by: Jinyang Yuan <[email protected]>
Co-authored-by: meatybobby <[email protected]>
XuesongYang pushed a commit to paarthneekhara/NeMo that referenced this pull request Jan 18, 2025
Signed-off-by: Jinyang Yuan <[email protected]>
Co-authored-by: Jinyang Yuan <[email protected]>
Co-authored-by: meatybobby <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants