Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(beep boop 🤖): Bump MCORE_TAG=67a50f2... (2024-11-28) #11427

Merged
merged 9 commits into from
Dec 5, 2024

Conversation

ko3n1g
Copy link
Collaborator

@ko3n1g ko3n1g commented Nov 28, 2024

🚀 PR to bump NVIDIA/Megatron-LM in Dockerfile.ci to MCORE_TAG=67a50f2f9b2f12b1361ac0f21fc3410b23e07d5e.

📝 Please remember the following to-do's before merge:

  • Verify the presubmit CI

🙏 Please merge this PR only if the CI workflow completed successfully.

@ko3n1g ko3n1g requested a review from pablo-garay as a code owner November 28, 2024 00:24
@ko3n1g ko3n1g changed the title chore(beep boop 🤖): Bump MCORE_TAG=3c2d6f8... (2024-11-28) chore(beep boop 🤖): Bump MCORE_TAG=67a50f2... (2024-11-28) Nov 28, 2024
@ko3n1g ko3n1g force-pushed the bump-ci-container--NVIDIA-Megatron-LM-2024-11-28 branch from dfec16a to cf48932 Compare November 28, 2024 12:21
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Nov 28, 2024
@github-actions github-actions bot added NLP and removed Run CICD labels Nov 28, 2024
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Nov 28, 2024
@github-actions github-actions bot added CI and removed Run CICD labels Nov 28, 2024
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Nov 29, 2024
@@ -4569,7 +4571,7 @@ jobs:
- L2_Megatron_Core_T5_Pretraining_and_Resume_Training_TP2
- L2_Megatron_T5_with_ALiBi_Pretraining_and_Resume_Training_TP2
- L2_Megatron_T5_with_KERPLE_Pretraining_and_Resume_Training_TP2
- L2_Megatron_T5_Pretraining_and_Resume_Training_PP2
- Optional_L2_Megatron_T5_Pretraining_and_Resume_Training_PP2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs # then . Same as right above change

@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Dec 5, 2024
Copy link
Contributor

github-actions bot commented Dec 5, 2024

[🤖]: Hi @ko3n1g 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

ko3n1g and others added 9 commits December 5, 2024 17:57
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Fix the fake parallel states init with moe parallel folding.

Signed-off-by: Dennis <[email protected]>

* Apply isort and black reformatting

Signed-off-by: Victarry <[email protected]>

---------

Signed-off-by: Dennis <[email protected]>
Signed-off-by: Victarry <[email protected]>
Co-authored-by: Victarry <[email protected]>
* Fix the fake parallel states init with moe parallel folding.

Signed-off-by: Dennis <[email protected]>

* Apply isort and black reformatting

Signed-off-by: Victarry <[email protected]>

* Update UT.

Signed-off-by: Dennis <[email protected]>

---------

Signed-off-by: Dennis <[email protected]>
Signed-off-by: Victarry <[email protected]>
Co-authored-by: Dennis <[email protected]>
Co-authored-by: Victarry <[email protected]>
Signed-off-by: Oliver Koenig <[email protected]>
Signed-off-by: Oliver Koenig <[email protected]>
Signed-off-by: Oliver Koenig <[email protected]>
Signed-off-by: Oliver Koenig <[email protected]>
Signed-off-by: Oliver Koenig <[email protected]>
@ko3n1g ko3n1g force-pushed the bump-ci-container--NVIDIA-Megatron-LM-2024-11-28 branch from 5b07c41 to a4bbdf3 Compare December 5, 2024 16:57
@ko3n1g ko3n1g merged commit 1f492d3 into main Dec 5, 2024
13 of 16 checks passed
@ko3n1g ko3n1g deleted the bump-ci-container--NVIDIA-Megatron-LM-2024-11-28 branch December 5, 2024 16:57
Copy link
Contributor

github-actions bot commented Dec 5, 2024

beep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.


Your code was analyzed with PyLint. The following annotations have been identified:

************* Module nemo.collections.nlp.modules.common.megatron.megatron_init
nemo/collections/nlp/modules/common/megatron/megatron_init.py:264:0: C0301: Line too long (122/119) (line-too-long)
nemo/collections/nlp/modules/common/megatron/megatron_init.py:265:0: C0301: Line too long (133/119) (line-too-long)
nemo/collections/nlp/modules/common/megatron/megatron_init.py:266:0: C0301: Line too long (121/119) (line-too-long)
nemo/collections/nlp/modules/common/megatron/megatron_init.py:369:0: C0301: Line too long (166/119) (line-too-long)
nemo/collections/nlp/modules/common/megatron/megatron_init.py:88:0: C0116: Missing function or method docstring (missing-function-docstring)
************* Module nemo.lightning.megatron_init
nemo/lightning/megatron_init.py:264:0: C0301: Line too long (122/119) (line-too-long)
nemo/lightning/megatron_init.py:265:0: C0301: Line too long (133/119) (line-too-long)
nemo/lightning/megatron_init.py:266:0: C0301: Line too long (121/119) (line-too-long)
nemo/lightning/megatron_init.py:369:0: C0301: Line too long (166/119) (line-too-long)
nemo/lightning/megatron_init.py:88:0: C0116: Missing function or method docstring (missing-function-docstring)

-----------------------------------
Your code has been rated at 9.78/10

Thank you for improving NeMo's documentation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants