-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NVTX ranges to categorize execution #11945
Conversation
d57eb00
to
b4891a4
Compare
beep boop 🤖: 🚨 The following files must be fixed before merge! Your code was analyzed with PyLint. The following annotations have been identified:
Mitigation guide:
By applying these rules, we reduce the occurance of this message in future. Thank you for improving NeMo's documentation! |
beep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base. Your code was analyzed with PyLint. The following annotations have been identified:
Mitigation guide:
By applying these rules, we reduce the occurance of this message in future. Thank you for improving NeMo's documentation! |
@marcromeyn @hemildesai Pinging for reviews, code has been updated to use NsysCallback and AppState |
48fa6d3
to
153a911
Compare
Signed-off-by: Jaemin Choi <[email protected]>
Signed-off-by: Jaemin Choi <[email protected]>
Signed-off-by: Jaemin Choi <[email protected]>
Signed-off-by: minitu <[email protected]> Signed-off-by: Jaemin Choi <[email protected]>
Signed-off-by: minitu <[email protected]> Signed-off-by: Jaemin Choi <[email protected]>
Signed-off-by: Jaemin Choi <[email protected]>
Signed-off-by: minitu <[email protected]> Signed-off-by: Jaemin Choi <[email protected]>
Signed-off-by: Jaemin Choi <[email protected]>
Signed-off-by: Jaemin Choi <[email protected]>
Signed-off-by: Jaemin Choi <[email protected]>
Signed-off-by: Jaemin Choi <[email protected]>
Signed-off-by: minitu <[email protected]> Signed-off-by: Jaemin Choi <[email protected]>
Signed-off-by: Jaemin Choi <[email protected]>
Signed-off-by: Jaemin Choi <[email protected]>
Signed-off-by: Jaemin Choi <[email protected]>
Signed-off-by: minitu <[email protected]> Signed-off-by: Jaemin Choi <[email protected]>
Signed-off-by: minitu <[email protected]> Signed-off-by: Jaemin Choi <[email protected]>
153a911
to
d55fbac
Compare
Signed-off-by: Jaemin Choi <[email protected]>
Signed-off-by: Jaemin Choi <[email protected]>
…into llama31_automated_breakdown
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What does this PR do ?
Adds NVTX ranges inside NeMo to categorize different parts of the execution.
For now the PR only adds an NVTX range around the MCore optimizer step.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use this
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information