Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Evo2 merge 20250214 #12263
Evo2 merge 20250214 #12263
Changes from 16 commits
995dc9c
55d6548
b2a4e19
e1b8b20
c0c4bbd
688e8ce
c28efaf
733a79d
363c015
54a361b
a32ac16
33d8957
9816ff1
fadacc3
020a508
a7a5092
9c3fb74
3df19a7
7d52494
dd14d63
02a4e35
d50f267
25e0ce0
e83d7bb
fc0bf3b
c081ba3
4480311
04eba8e
4b55408
8b9fdb2
4d1fe01
266c722
c83ef09
21300b0
a9867cc
9111382
471c9bf
5d2b612
d280df1
fe99a49
fa3fac0
d8ac417
30a7824
2be3af5
7921c44
081ae40
8f32cbf
8b8b515
ae7a387
8ca01eb
44d08b5
3c1b74e
5ced598
353d346
8a7fa12
a6971ca
9b4737b
bc69b7a
3ea659b
1db1d3b
c77f262
7fc0637
faf8f3f
b0e1d74
917271c
aee348c
31c132f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the reason for this
megatron
folder in llm/gpt/data?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are sub-classes of megatron data modules that were decided shouldn't go into the megatron-lm repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this method is in this file? we used to have it in bionemo, do you need it in NeMo? if yes, then it shouldn't be under megatron/hyena
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also, shouldn't Evo2BlendedDatasetConfig in fact be BlendedDatasetConfig and be located somewhere here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems that in NeMo you pass mostly paths from command line
NeMo/scripts/llm/gpt_distillation.py
Line 109 in b94bff7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the same goes for megatron https://github.com/NVIDIA/Megatron-LM/blob/36753c7f7cf8c72b5a43c0ae309c36909ddf1b02/examples/academic_paper_scripts/detxoify_lm/finetune_gpt.py#L111