Make NFA subtitles stay until end of video #7189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntil end of video Signed-off-by: Elena Rastorgueva <[email protected]>
erastorgueva-nv
force-pushed
the
nfa_subtitles_stay_at_end
branch
from
60f98c7 to
93ba738
Compare
titu1994
reviewed
Aug 9, 2023
titu1994
previously approved these changes
Aug 9, 2023
Signed-off-by: Elena Rastorgueva <[email protected]>
dorotat-nv
pushed a commit
to dorotat-nv/NeMo
that referenced
this pull request
Aug 24, 2023
* write extra subtitles line to make sure final subtitles are visible until end of video Signed-off-by: Elena Rastorgueva <[email protected]> * add some comments for final subtitle line logic Signed-off-by: Elena Rastorgueva <[email protected]> --------- Signed-off-by: Elena Rastorgueva <[email protected]> Signed-off-by: dorotat <[email protected]>
rohitrango
pushed a commit
to rohitrango/NeMo
that referenced
this pull request
Jun 25, 2024
* write extra subtitles line to make sure final subtitles are visible until end of video Signed-off-by: Elena Rastorgueva <[email protected]> * add some comments for final subtitle line logic Signed-off-by: Elena Rastorgueva <[email protected]> --------- Signed-off-by: Elena Rastorgueva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Write an extra line at the end of the ASS files which will ensure the subtitles of the final segment are visible until the end of the video. Without this, it means that if we create an MP4 file from an audio file by writing the subtitles on a plain background, at the end of the video we are always left with a blank screen, which is not a nice UX as the text feels to disappear very suddenly.
Collection:
tools/nemo_forced_aligner.pyChangelog
Usage
No change in usage.
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information