Upgrade hydra and omegaconf #7243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abhishree <[email protected]>
Signed-off-by: Abhishree Thittenamane <[email protected]>
dorotat-nv
pushed a commit
to dorotat-nv/NeMo
that referenced
this pull request
Aug 24, 2023
* Upgrade hydra and omegaconf Signed-off-by: Abhishree <[email protected]> * Edit omegaconf version Signed-off-by: Abhishree Thittenamane <[email protected]> --------- Signed-off-by: Abhishree <[email protected]> Signed-off-by: Abhishree Thittenamane <[email protected]> Signed-off-by: dorotat <[email protected]>
odelalleau
reviewed
Sep 7, 2023
| hydra-core>=1.2.0,<1.3 | ||
| omegaconf>=2.2,<2.3 | ||
| hydra-core>1.3,<=1.3.2 | ||
| omegaconf<=2.3 |
There was a problem hiding this comment.
I'm a bit surprised why this isn't
hydra-core>=1.3.2,<1.4
omegaconf>=2.2.3,<2.4
Motivation:
- For Hydra: looks like the goal is to upgrade to 1.3, so best take at least the latest minor 1.3 release, but prevent upgrading to 1.4 which might contain breaking changes. It's unclear why we'd want only 1.3.1 or 1.3.2 (which is what this PR does).
- For OmegaConf: take at least the latest minor 2.2 version, allow 2.3.x since there were no breaking changes in 2.3.0 compared to 2.2, but prevent upgrading to 2.4 which might contain breaking changes.
@titu1994 why these specific choices?
rohitrango
pushed a commit
to rohitrango/NeMo
that referenced
this pull request
Jun 25, 2024
* Upgrade hydra and omegaconf Signed-off-by: Abhishree <[email protected]> * Edit omegaconf version Signed-off-by: Abhishree Thittenamane <[email protected]> --------- Signed-off-by: Abhishree <[email protected]> Signed-off-by: Abhishree Thittenamane <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information