Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging model checkpoints as artifacts in MlFlow #7258

Merged
merged 2 commits into from
Aug 23, 2023

Conversation

AlirezaMorsali
Copy link
Contributor

@AlirezaMorsali AlirezaMorsali commented Aug 17, 2023

What does this PR do ?

MlFlow is required for training and resuming runs from checkpoint. Currently, when the MlFlow logger is enabled in experiment manager it doesn't log model checkpoint as artifacts to MLFlow.
This PR simply adds one line to the nemo.utils.loggers.MLFlowParams to allow for logging checkpoints.

Collection: [Note which collection this PR will affect]

Changelog

  • Add log_model to nemo.utils.loggers.MLFlowParams

Usage

To enable logging checkpoints in MlFlow

exp_manager:
  ...
  create_checkpoint_callback: True
  create_mlflow_logger: True
  mlflow_logger_kwargs:
  ...
      log_model: True

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

Signed-off-by: Alireza Morsali <[email protected]>
@AlirezaMorsali AlirezaMorsali changed the title add log_model to MLFlowParams Logging model checkpoints as artifacts in MlFlow Aug 17, 2023
Copy link
Collaborator

@titu1994 titu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@titu1994 titu1994 merged commit d091675 into NVIDIA:main Aug 23, 2023
dorotat-nv pushed a commit to dorotat-nv/NeMo that referenced this pull request Aug 24, 2023
Signed-off-by: Alireza Morsali <[email protected]>
Signed-off-by: dorotat <[email protected]>
rohitrango pushed a commit to rohitrango/NeMo that referenced this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants