Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comprehensive error messages #7261

Merged

Conversation

PeganovAnton
Copy link
Contributor

@PeganovAnton PeganovAnton commented Aug 17, 2023

What does this PR do ?

Adds comprehensive error messages for cases when input has wrong type

Collection: nlp

Changelog

  • Add a couple of error messages

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@PeganovAnton PeganovAnton self-assigned this Aug 17, 2023
@github-actions github-actions bot added the NLP label Aug 17, 2023
@PeganovAnton PeganovAnton force-pushed the fix/comprehensive_error_messages_on_wrong_input_type branch from 050440e to bab6fa9 Compare August 17, 2023 19:40
Copy link
Collaborator

@aleksficek aleksficek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but we should get someone more active in NeMo to also approve before merging

@github-actions
Copy link
Contributor

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

@github-actions github-actions bot added the stale label Sep 12, 2023
@MaximumEntropy MaximumEntropy merged commit 5ccb70f into main Sep 12, 2023
@MaximumEntropy MaximumEntropy deleted the fix/comprehensive_error_messages_on_wrong_input_type branch September 12, 2023 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants