Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adithyare/peft metric calculation #7304

Merged
merged 4 commits into from
Aug 25, 2023
Merged

Conversation

arendu
Copy link
Collaborator

@arendu arendu commented Aug 23, 2023

What does this PR do ?

replaces squad_metric_calc.py with peft_metric_calc.py which computes f1 and accuracy and rouge at once.

Collection: []

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@arendu arendu requested a review from Davood-M August 23, 2023 18:55
Copy link
Collaborator

@Davood-M Davood-M left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@arendu arendu merged commit 977b382 into main Aug 25, 2023
@arendu arendu deleted the adithyare/peft_metric_calculation branch August 25, 2023 23:50
rohitrango pushed a commit to rohitrango/NeMo that referenced this pull request Jun 25, 2024
* all purpose metric calculation script, computes f1/accuracy/rouge

Signed-off-by: Adi Renduchintala <[email protected]>

* removed squad metric calc script

Signed-off-by: Adi Renduchintala <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Adi Renduchintala <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants