Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin mcore to 0.3 #7751

Merged
merged 4 commits into from
Oct 19, 2023
Merged

Pin mcore to 0.3 #7751

merged 4 commits into from
Oct 19, 2023

Conversation

ericharper
Copy link
Collaborator

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: eharper <[email protected]>
@github-actions github-actions bot added the CI label Oct 18, 2023
@ericharper ericharper merged commit be47a3d into r1.21.0 Oct 19, 2023
10 checks passed
@ericharper ericharper deleted the update_mcore_req branch October 19, 2023 02:08
github-actions bot pushed a commit that referenced this pull request Oct 19, 2023
* pin mcore to 0.3

Signed-off-by: eharper <[email protected]>

* upper bound tensorstore

Signed-off-by: eharper <[email protected]>

* upper bound opencc

Signed-off-by: eharper <[email protected]>

---------

Signed-off-by: eharper <[email protected]>
ericharper added a commit that referenced this pull request Oct 19, 2023
* pin mcore to 0.3



* upper bound tensorstore



* upper bound opencc



---------

Signed-off-by: eharper <[email protected]>
Co-authored-by: Eric Harper <[email protected]>
burchim pushed a commit to burchim/NeMo that referenced this pull request Oct 28, 2023
* pin mcore to 0.3

* upper bound tensorstore

* upper bound opencc

---------

Signed-off-by: eharper <[email protected]>
Co-authored-by: Eric Harper <[email protected]>
Signed-off-by: maxime burchi <[email protected]>
pzelasko pushed a commit to pzelasko/NeMo that referenced this pull request Jan 3, 2024
* pin mcore to 0.3

* upper bound tensorstore

* upper bound opencc

---------

Signed-off-by: eharper <[email protected]>
Co-authored-by: Eric Harper <[email protected]>
Signed-off-by: Piotr Żelasko <[email protected]>
rohitrango pushed a commit to rohitrango/NeMo that referenced this pull request Jun 25, 2024
* pin mcore to 0.3



* upper bound tensorstore



* upper bound opencc



---------

Signed-off-by: eharper <[email protected]>
Co-authored-by: Eric Harper <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant