-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add safetensors #7812
Add safetensors #7812
Conversation
* update text server to support compute logprobs * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix typo --------- Signed-off-by: Zhilin Wang <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: coldwaterq <[email protected]>
Signed-off-by: Mikołaj Błaż <[email protected]> Signed-off-by: coldwaterq <[email protected]>
Still running tests to make sure nothing is negatively impacted. Signed-off-by: coldwaterq <[email protected]>
Signed-off-by: coldwaterq <[email protected]>
Signed-off-by: coldwaterq <[email protected]>
This reverts commit 7bb4049. Signed-off-by: coldwaterq <[email protected]>
for more information, see https://pre-commit.ci
@@ -464,7 +464,7 @@ | |||
) | |||
super().__init__() | |||
|
|||
def save_to(self, model, save_path: str): | |||
def save_to(self, model, save_path: str, safe: bool = False): |
Check notice
Code scanning / CodeQL
Explicit returns mixed with implicit (fall through) returns
save_path = save_path.replace(".nemo", "_XYZ.nemo") | ||
super().save_to(model, save_path, safe=safe) | ||
|
||
class MockModelV2(MockModel): |
Check notice
Code scanning / CodeQL
Unused local variable
Signed-off-by: Eric Harper <[email protected]>
/jenkins |
Signed-off-by: Eric Harper <[email protected]>
/jenkins |
jenkins |
2 similar comments
jenkins |
jenkins |
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days. |
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days. |
This PR was closed because it has been inactive for 7 days since being marked as stale. |
What does this PR do ?
By default, state_dicts are being saved as pytorch files which contain pickles. This is a security concern which this PR attempts to start the mitigation for while preserving backwards compatability.
Collection: all, but none specifically (core functionality)
Changelog
Usage
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information