Fix the typo of FusedRMSNorm doc #1869
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crcrpar
approved these changes
Dec 31, 2024
| @@ -745,8 +745,7 @@ class FusedLayerNorm(torch.nn.Module): | |||
| normalize over the last dimension which is expected to be of that specific size. | |||
| eps: a value added to the denominator for numerical stability. Default: 1e-5 | |||
| elementwise_affine: a boolean value that when set to ``True``, this module | |||
| has learnable per-element affine parameters initialized to ones (for weights) | |||
| and zeros (for biases). Default: ``True``. | |||
| has learnable per-element affine parameters initialized to ones for weights. Default: ``True``. | |||
There was a problem hiding this comment.
Suggested change
| has learnable per-element affine parameters initialized to ones for weights. Default: ``True``. | |
| has learnable per-element affine parameters initialized to ones for weights. Default: :obj:`True`. |
There was a problem hiding this comment.
Submitted a newer version:
- use :obj: as recommended
- fix the previous pr's issue(mistakenly modified FusedLayerNorm rather than FusedRMSNorm )
AumGupta
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the typo of FusedRMSNorm doc in normalization/fused_layer_norm.py