Deprecate thrust::optional #3307
Open
+36
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernhardmgruber
added
thrust
bernhardmgruber
force-pushed
the
depr_optional
branch
from
e7b8e50 to
d82c06c
Compare
miscco
reviewed
Jan 9, 2025
| @@ -59,11 +61,10 @@ THRUST_NAMESPACE_BEGIN | |||
| #ifndef THRUST_MONOSTATE_INPLACE_MUTEX | |||
| # define THRUST_MONOSTATE_INPLACE_MUTEX | |||
| /// \brief Used to represent an optional with no data; essentially a bool | |||
| class monostate | |||
| {}; | |||
| class CCCL_DEPRECATED monostate{}; | |||
There was a problem hiding this comment.
Should we use CCCL_DEPRECATED_BECAUSE("Use cuda::std::monostate instead")
| template <typename X, typename Deleter> | ||
| _CCCL_HOST optional<unique_stream> try_acquire_stream(int, std::unique_ptr<X, Deleter>&) noexcept | ||
| template <typename X, typename Deleter> | ||
| _CCCL_HOST optional<unique_stream> try_acquire_stream(int, std::unique_ptr<X, Deleter>&) noexcept |
There was a problem hiding this comment.
I would rather just use cuda::std::optional here
There was a problem hiding this comment.
That's what I tried, but you need C++17 for that :D. Also, this PR will be backported to 2.8 where we only have C++11 as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3306