Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bug: expose public device APIs #127

Merged
merged 1 commit into from
Dec 15, 2021
Merged

Fix a bug: expose public device APIs #127

merged 1 commit into from
Dec 15, 2021

Conversation

PointKernel
Copy link
Member

This is a follow-up PR of #126. A new device_view_base class is added to remove redundancy and expose the following public APIs in both device_view and device_mutable_view:

  • get_empty_key_sentinel()
  • get_empty_value_sentinel()
  • get_slots()
  • get_capacity()

@PointKernel PointKernel added the type: bug Something isn't working label Dec 14, 2021
@PointKernel PointKernel force-pushed the expose-device-public-apis branch from 79e2a18 to 8187626 Compare December 15, 2021 18:42
@PointKernel
Copy link
Member Author

Force pushed an empty commit to trigger CI checks.

@PointKernel PointKernel merged commit d473fac into NVIDIA:dev Dec 15, 2021
@PointKernel PointKernel deleted the expose-device-public-apis branch December 15, 2021 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrhemstad jrhemstad jrhemstad approved these changes

Assignees
No one assigned
Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PointKernel @jrhemstad