Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct issues when INSTALL_CUCO is set to OFF #226

Merged
merged 2 commits into from
Sep 1, 2022
Merged

Correct issues when INSTALL_CUCO is set to OFF #226

merged 2 commits into from
Sep 1, 2022

Conversation

robertmaynard
Copy link
Collaborator

While #216 allows cuco to have install rules disabled it missed a couple of bits which are corrected with this PR:

  • nvbench and google bench still installed files
  • when INSTALL_CUCO is OFF we still need to generate a cuco-config in the build directory

@robertmaynard robertmaynard added type: bug Something isn't working topic: build CMake build issue Needs Review Awaiting reviews before merging labels Aug 30, 2022
@vyasr
Copy link
Collaborator

vyasr commented Aug 31, 2022

@PointKernel do you know what the failing test here is about? Naively it looks like a GH check to make sure that the PR is listed on a GH project, but this repo doesn't have any projects AFAICT so I'm not sure that's what it's asking for.

@PointKernel
Copy link
Member

Naively it looks like a GH check to make sure that the PR is listed on a GH project, but this repo doesn't have any projects AFAICT so I'm not sure that's what it's asking for.

We can still merge the PR while the project-check is failed. @jrhemstad may know the right way to handle this.

@jrhemstad
Copy link
Collaborator

Yeah, you can ignore that. It's been fixed and I don't know how to retrigger that check.

@PointKernel
Copy link
Member

PointKernel commented Sep 1, 2022 •
edited
Loading

rerun tests

Not working as expected.

@robertmaynard
Copy link
Collaborator Author

Should I re-open as a new PR?

@PointKernel PointKernel merged commit 77593b3 into NVIDIA:dev Sep 1, 2022
@PointKernel
Copy link
Member

Should I re-open as a new PR?

No need to make things complicated. I just merged it as it is.

@bdice bdice mentioned this pull request Sep 6, 2022
Merged
@robertmaynard robertmaynard deleted the improve_install_rules branch September 6, 2022 15:57
rapids-bot bot pushed a commit to rapidsai/rapids-cmake that referenced this pull request Sep 6, 2022
@bdice
Update cuCollections to fix issue with INSTALL_CUCO set to OFF. (#261)
ee08ba8 
This updates the cuCollections version to include a fix for when `INSTALL_CUCO` is set to `OFF`: NVIDIA/cuCollections#226

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Robert Maynard (https://github.com/robertmaynard)

URL: #261
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PointKernel PointKernel PointKernel approved these changes

Assignees
No one assigned
Labels
Needs Review Awaiting reviews before merging topic: build CMake build issue type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@robertmaynard @vyasr @PointKernel @jrhemstad