Clang warning: using the result of an assignment as a condition

[andrewcorrigan]

An assignment within an if-statement introduced in [bac2060] triggers a warning with Clang:

In file included from /thrust/cub/block/../iterator/cache_modified_input_iterator.cuh:42:
/thrust/cub/block/../iterator/../util_device.cuh:323:35: warning: using the result of an assignment as a condition without parentheses [-Wparentheses]
                if (payload.error = std::forward<Invocable>(f)(payload.attribute))
                    ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/thrust/cub/block/../iterator/../util_device.cuh:323:35: note: place parentheses around the assignment to silence this warning
                if (payload.error = std::forward<Invocable>(f)(payload.attribute))
                                  ^
                    (                                                            )
/thrust/cub/block/../iterator/../util_device.cuh:323:35: note: use '==' to turn this assignment into an equality comparison
                if (payload.error = std::forward<Invocable>(f)(payload.attribute))
                                  ^
                                  ==

Would it make sense to split this into two lines?

                payload.error = std::forward<Invocable>(f)(payload.attribute);
                if (payload.error)

[alliepiper]

Would it make sense to split this into two lines?

Sounds good to me.