Fix unset version in structs #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change ensures that the Version field is set in structs that require them. This addresses the following calls: * DeviceGetRunningProcessDetailList * DeviceGetPciInfoExt * DeviceGetVgpuHeterogeneousMode * DeviceGetSupportedPlacements * DeviceGetCreatablePlacements * DeviceGetVgpuProcessesUtilizationInfo * DeviceGetSramEccErrorStatus * SystemGetConfComputeKeyRotationThresholdInfo * SystemGetConfComputeSettings Signed-off-by: Evan Lezar <[email protected]>
|
How did you evaluate which functions needed this to ensure we didn't miss any? |
I searched the generated types for |
|
Not worth the overhead yet, I'd say, but need to watch out for this as new functions / types get added from release to release |
klueska
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that the Version field is set in structs that require them.
This addresses the following calls:
This replaces replace #130
fixes #138