-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fallback ErrorString function #99
Conversation
Does this mimic what we did in go-nvlib? |
The Note that when we originally implemented the logic in |
Seems reasonable. Given that we only end up calling this on error conditions, the extra bit of time to look up the symbol should be negligible. |
This change adds a fallback ErrorString function that is used when the nvmlErrorString function cannot be resolved. For example, when the library is not loaded. Signed-off-by: Evan Lezar <[email protected]>
92462de
to
b9853b2
Compare
Yes, you're right. Thanks for your PR. I think it would be better to invert the return statements. |
This change adds a fallback ErrorString function that is used when the nvmlErrorString function cannot be resolved. For example, when the library is not loaded.
Closes #82