Append UID to config name

[ArangoGutierrez]

When running parallel workflows we need to have UID for each instance to avoid them having the same name

[ArangoGutierrez]

Inspired by NVIDIA/gpu-operator#721 that is proposing parallel runs

[elezar]

Do we want to add a comment as to why this is done?

Suggested change

	"math/rand" //nolint:all
	"math/rand" //nolint:gosec // We use randomization for appending unique suffixes and this need not be cryptographically secure.

[elezar]

Question: Is the lint error reported here or at the import?

[elezar]

It would be reported here. Tested in the device plugin:

 ✗ make check
golangci-lint run ./...
tests/e2e/framework/framework.go:149:53: G404: Use of weak random number generator (math/rand instead of crypto/rand) (gosec)
                f.UniqueName = fmt.Sprintf("%s-%08x", f.BaseName, rand.Int31())
                                                                  ^
tests/e2e/framework/util.go:50:22: G404: Use of weak random number generator (math/rand instead of crypto/rand) (gosec)
        return strconv.Itoa(rand.Intn(10000))
                            ^
make: *** [Makefile:81: lint] Error 1

[ArangoGutierrez]

done

[elezar]

I mean, do we want to add the nolint here and NOT at the import.

[ArangoGutierrez]

I did a run without the comment on both

❯ golangci-lint run ./... |grep weak

and golangci-lint didn't complained

[ArangoGutierrez]

I have edited it to only have the lint comment on the code and not the import.

[elezar]

This project doesn't seem to have a .golangci file. Could that be why we're not seeing the issue?

[ArangoGutierrez]

I copied the one from device-plug repo thinking the same, and got no error

❯ golangci-lint --version
golangci-lint has version 1.59.0 built with go1.22.3 from 2059b18 on 2024-05-25T11:38:08Z

[ArangoGutierrez]

Updated as discussed @elezar